Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing outputs metadata to action.yml #127

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented May 29, 2024

This PR adds outputs metadata to action.yml. The metadata is explained in the following official document:

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#outputs-for-docker-container-and-javascript-actions

Though it is optional, the metadata is useful for some static analysis. For example, actionlint can statically check the outputs are used correctly in a workflow.

@rhysd
Copy link
Contributor Author

rhysd commented Jun 11, 2024

CI failed but the reason doesn't seem related to this PR change:

Attempting to download 12.22.12...
Not found in manifest. Falling back to download directly from Node
Error: Unable to find Node version '12.22.12' for platform darwin and architecture arm64.

I guess this is caused by that Node.js v12 reached the end of life and Node.js dropped the support.

@zkochan zkochan merged commit 5d79380 into pnpm:master Jun 12, 2024
25 of 27 checks passed
jmikedupont2 pushed a commit to meta-introspector/action-setup that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants