Apply suggestions from code review

Add typing where missing. Remove extra underscore from method. Reference: pypa#1897 Philippe Ombredanne <[email protected]> Co-authored-by: Cooper Lees <[email protected]>
pombredanne · Mar 6, 2025 · 262a137 · 262a137
1 parent f93e687
commit 262a137
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/bandersnatch/master.py b/src/bandersnatch/master.py
@@ -157,7 +157,7 @@ async def fetch_simple_index(self) -> Any:
             simple_index = await response.json()
         return simple_index
 
-    async def all_packages(self) -> Any:
+    async def all_packages(self) -> dict[str, int]:
         """Return a mapping of all project names as {name: last_serial}"""
         simple_index = await self.fetch_simple_index()
         if not simple_index:

diff --git a/src/bandersnatch/tests/test_master.py b/src/bandersnatch/tests/test_master.py
@@ -78,7 +78,7 @@ async def test_master_url_fetch(master: Master) -> None:
 
 
 @pytest.mark.asyncio
-async def test__simple_index_user_agent(master: Master) -> None:
+async def test_simple_index_user_agent(master: Master) -> None:
     headers = master._custom_headers
     assert f"bandersnatch {bandersnatch.__version__}" in headers["User-Agent"]