New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInput: use Cow instead of reference for label, helper text and error text #773

Merged

mmstick merged 1 commit into pop-os:master from sgued:text-input-cow-label

Jan 16, 2025

Contributor

sgued commented Jan 3, 2025 •

edited

Loading

This is useful to be able to translate the label directly in the view function, instead of having to store a translation in the app state.


          TextInput: use Cow instead of reference for label, helper text and er…

…ror text

Contributor Author

sgued commented Jan 3, 2025

I also notice that error is never used.

mmstick approved these changes

View reviewed changes

mmstick merged commit 90c5c84 into pop-os:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet