-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* A rough idea for supporting the `mask` argument in `GT.tab_style()` * Ensure the `mask=` argument is used exclusively without specifying `columns` or `rows` * Add tests for `resolve_mask_i()` * Update test name * Replace ambiguous variable name `masks` with `cellpos_data` * Update the `resolve_mask_i()` logic based on team feedback * Replace `assert` with `raise ValueError()` * Update test cases for `GT.tab_style()` * Add additional test cases for `resolve_mask_i()` * Add docstring for `mask=` in `LocBody` * Use `df.height` to get the number of rows in a DataFrame * Rename `resolve_mask_i` to `resolve_mask` * Apply code review suggestions for the `mask=` implementation in `LocBody`
- Loading branch information
Showing
2 changed files
with
146 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters