Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to dev shiny and htmltools #172

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Update to dev shiny and htmltools #172

merged 2 commits into from
Aug 28, 2024

Conversation

cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Aug 28, 2024 •
edited
Loading

  • 4ff1c65 reproduces the CI failure we're seeing on py-shiny -- make all now fails with the recent switch to pyproject.toml.
  • 78b86a0 proposes a fix. Note that this fix will only work for the latest dev version of Shiny.

@cpsievert cpsievert requested a review from wch August 28, 2024 15:11
@cpsievert cpsievert marked this pull request as ready for review August 28, 2024 15:11
@cpsievert cpsievert merged commit 712d568 into main Aug 28, 2024
2 checks passed
@cpsievert cpsievert deleted the updates-for-pyproject-toml branch August 28, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpsievert @wch