Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airplay: Add setting for MRP tunnel #2630

Merged
merged 1 commit into from
Feb 28, 2025
Merged

airplay: Add setting for MRP tunnel #2630

merged 1 commit into from
Feb 28, 2025

Conversation

postlund
Copy link
Owner

It is now possible to force or disable set up of MRP over AirPlay tunnel over Airplay (or the default "auto" mode). If set up of remote control fails, that will now render an exception (just like with other protocols on an error) instead of just a log message.

Relates to #2629

@postlund postlund added the airplay AirPlay related issue label Feb 28, 2025
@postlund postlund self-assigned this Feb 28, 2025
@postlund postlund marked this pull request as ready for review February 28, 2025 14:09
It is now possible to force or disable set up of MRP over AirPlay tunnel
over Airplay (or the default "auto" mode). If set up of remote control
fails, that will now render an exception (just like with other protocols
on an error) instead of just a log message.

Relates to #2629
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 36.95652% with 29 lines in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (9c221d1) to head (00f3d96).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pyatv/protocols/airplay/__init__.py 17.14% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2630      +/-   ##
==========================================
- Coverage   88.96%   88.93%   -0.04%     
==========================================
  Files         168      168              
  Lines       11555    11574      +19     
==========================================
+ Hits        10280    10293      +13     
- Misses       1275     1281       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@postlund postlund merged commit e27164b into master Feb 28, 2025
19 of 21 checks passed
@postlund postlund deleted the mrp_tunnel branch February 28, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airplay AirPlay related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant