Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double quotes to SSID name #894

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

henriquetorquato
Copy link
Contributor

Types of Changes

Bugfix for issue #893

Verification

  • Will write tests for the feature
  • Will burn build on my Cardputer and test it against network

Linked Issues

#893

User-Facing Change

NONE

Further Comments

@bmorcelli
Copy link
Collaborator

Can you test if your changes don't break wigle compatibility?

This csv wasn't meant to be opened on a computer, but in wigle.. if with your changes it still works there without human interference, it's ok for me

@henriquetorquato
Copy link
Contributor Author

@bmorcelli will do.

@henriquetorquato
Copy link
Contributor Author

@bmorcelli it seems that those broken entries were previously ignored. I've uploaded the original file and a new file that was modified by hand:

image

@henriquetorquato
Copy link
Contributor Author

@bmorcelli I just tested out the change on my m5 cardputed and it works. Sample from just opening the file:
image

@bmorcelli
Copy link
Collaborator

Great.. I'll merge it then

@bmorcelli bmorcelli merged commit 26af689 into pr3y:main Mar 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants