Impression tracker for original API #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
YuriyVelichkoPI
requested changes
Nov 20, 2024
PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/AdUnit.java
Show resolved
Hide resolved
PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/AdUnit.java
Show resolved
Hide resolved
YuriyVelichkoPI
requested changes
Feb 10, 2025
PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/AdUnit.java
Outdated
Show resolved
Hide resolved
PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/AdUnit.java
Show resolved
Hide resolved
| @@ -101,7 +101,7 @@ class GamOriginalInstreamNewApiFragment : AdFragment() { | |||
|
|
|||
| override fun onDestroyView() { | |||
| super.onDestroyView() | |||
| adUnit?.stopAutoRefresh() | |||
There was a problem hiding this comment.
This change looks as potential memory leak. What if the publisher utilizes a new counting methodology and will not call destroy()?
There was a problem hiding this comment.
If a user uses this burl tracker, it's better to use destroy(). Otherwise the monitor will traverse view hierarchy as long as the ad view container exists.
More verbose logs.
ValentinPostindustria
force-pushed
the
feature/burl_tracker
branch
from
8995039 to
801b7df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.