Fix #3592. Bad Input Error if pbjs s2s config contains alias configuration for a disabled adapter #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxPhoenix
changed the title
zxPhoenix
force-pushed
the
fix-fallen-auction-for-a-disabled-adapter
branch
from
22c0aa7 to
ff61c81
Compare
|
The issue is in Community Review status, so we will wait for confirmation |
CTMBNara
requested changes
Jan 17, 2025
| @@ -111,6 +112,7 @@ public Future<WithPodErrors<AuctionContext>> fromRequest(RoutingContext routingC | |||
| .compose(httpRequest -> createBidRequest(httpRequest) | |||
| .map(bidRequest -> removeEmptyEids(bidRequest, initialAuctionContext.getDebugWarnings())) | |||
| .compose(bidRequest -> validateRequest( | |||
| initialAuctionContext.getAccount(), | |||
There was a problem hiding this comment.
initialAuctionContext.getAccount() will always return null here
There was a problem hiding this comment.
I think we can accept it this way, since we haven't supported Video endpoint for many months now.
Comment on lines
332
to
353
| public void updateAdapterRequestDisabledBidderMetric(String bidder, Account account) { | ||
| forAdapter(bidder).request().incCounter(MetricName.disabled_bidder); | ||
| if (accountMetricsVerbosityResolver.forAccount(account) | ||
| .isAtLeast(AccountMetricsVerbosityLevel.detailed)) { | ||
| forAccount(account.getId()).adapter().forAdapter(bidder).request().incCounter(MetricName.disabled_bidder); | ||
| } | ||
| } | ||
|
|
||
| public void updateAdapterRequestUnknownBidderMetric(String bidder, Account account) { | ||
| forAdapter(bidder).request().incCounter(MetricName.unknown_bidder); | ||
| if (accountMetricsVerbosityResolver.forAccount(account) | ||
| .isAtLeast(AccountMetricsVerbosityLevel.detailed)) { | ||
| forAccount(account.getId()).adapter().forAdapter(bidder).request().incCounter(MetricName.unknown_bidder); | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't like this solution. Someone can spam the server with invalid bidders and load the memory by creating new entries in the map (with many invalid bidders).
|
@zxPhoenix could you please update this PR? |
Sure. Sorry for the delay. I have prioritised this PR. |
zxPhoenix
force-pushed
the
fix-fallen-auction-for-a-disabled-adapter
branch
from
ff61c81 to
3119f39
Compare
CTMBNara
requested changes
Feb 7, 2025
Comment on lines
1037
to
1038
| @Value("${settings.fail-on-disabled-bidders}") boolean failOnDisabledBidders, | ||
| @Value("${settings.fail-on-unknown-bidders}") boolean failOnUnknownBidders) { |
There was a problem hiding this comment.
Please, add default values as on line above
Comment on lines
516
to
517
| private void validateAliases(Map<String, String> aliases, List<String> warnings, | ||
| Metrics metrics, Account account) throws ValidationException { |
There was a problem hiding this comment.
No need to pass Metrics here, it's not a static method
Comment on lines
525
to
526
| final String message = String.format("request.ext.prebid.aliases.%s refers to unknown bidder: %s", | ||
| alias, coreBidder); |
There was a problem hiding this comment.
"request.ext.prebid.aliases.%s refers to unknown bidder: %s".format(alias, coreBidder);
Comment on lines
535
to
536
| final String message = String.format("request.ext.prebid.aliases.%s refers to disabled bidder: %s", | ||
| alias, coreBidder); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Fix issue #3592. Bad Input Error if pbjs s2s config contains alias configuration for a disabled adapter.
Move unknown bidder and bidder is deactivated errors to warnings level.
Add unknown_bidder and deactivated_bidder metrics
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
Changes are covered by unit tests.
🏎 Quality check