Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpp support true #5441

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

rishko00
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 6b9e888
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67a4c57e7129bc0008587d07
😎 Deploy Preview https://deploy-preview-5441--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -6,6 +6,7 @@ biddercode: smartyads
gvl_id: 534
tcfeu_supported: true
usp_supported: true
gpp_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new gpp_sids field instead of this deprecated one.

gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp

specify the sections you support

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishko00 any updates on this one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishko00 we would like to resolve this PR. Is there any progress on this one?

@muuki88
Copy link
Contributor

muuki88 commented Jun 19, 2024

@rishko00 can you also link the pull request in prebid.js / prebid server associated with this?

@bretg
Copy link
Contributor

bretg commented Oct 11, 2024

@rishko00 - please fix. gpp_supported is no longer supported. We need to know which specific sids you need. e.g.

gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp

@rishko00
Copy link
Contributor Author

rishko00 commented Feb 6, 2025

@bretg @muuki88 sorry for the delay, guys. I’ve pushed the changes.

@muuki88 muuki88 added LGTM and removed needs work labels Feb 6, 2025
@muuki88 muuki88 merged commit a6b4850 into prebid:master Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants