Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Remove old CircleCI jobs #24280

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

czentgr
Copy link
Contributor

@czentgr czentgr commented Dec 18, 2024

This removes the remaining CircleCI jobs from the repo so they won’t get run on new PRs.

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 18, 2024
@prestodb-ci prestodb-ci requested review from a team, wanglinsong and pratyakshsharma and removed request for a team December 18, 2024 19:50
@czentgr czentgr requested a review from majetideepak December 18, 2024 19:50
@czentgr
Copy link
Contributor Author

czentgr commented Dec 18, 2024

@majetideepak FYI
@tdcmeehan This is the PR to remove the CircleCI jobs. Once the service is deactivated these are expected to fail and cause PR failures.
There is one more change we need to make to handle the builds after the PR has merged to match with what we did with the CircleCI previously. See #24279
The current run of the CI with Github actions looks pretty stable and gives the desired results. With the last PR we should also improve the build times for new PRs quite a bit - currently, each new PR has no initial cache but once we get the master branch builds this should improve.

Edit: there is a check CircleCI Pipeline that wants the configuration and fails if removed. This isn't coming from a Github action but maybe set in the settings somewhere in Github as an integration point?

@czentgr czentgr force-pushed the cz_remove_circleci_jobs branch from bbf0662 to 8c3e658 Compare December 30, 2024 18:29
@czentgr czentgr marked this pull request as ready for review January 2, 2025 13:56
@czentgr czentgr requested a review from a team as a code owner January 2, 2025 13:56
@czentgr czentgr requested a review from presto-oss January 2, 2025 13:56
@czentgr czentgr force-pushed the cz_remove_circleci_jobs branch from 8c3e658 to 9b2a651 Compare January 7, 2025 20:23
This removes the remaining CircleCI jobs from the repo so they won’t get run
on new PRs.
@czentgr czentgr force-pushed the cz_remove_circleci_jobs branch from 9b2a651 to 69cbffc Compare January 8, 2025 19:54
@czentgr czentgr merged commit 378a4d4 into prestodb:master Jan 13, 2025
52 checks passed
@czentgr czentgr deleted the cz_remove_circleci_jobs branch January 13, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants