Identify some unused WRAM variables #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwimmingLink
added a commit
to SwimmingLink/SwimmingLinksPokeRed
that referenced
this pull request
Jun 28, 2024
Identify some unused WRAM variables (pret#453)
kqesar
pushed a commit
to kqesar/pokered
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit fc23e72)
PokefanMarcel
pushed a commit
to PokefanMarcel/yumepokered
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly things that only get read/written in one or two places and can't really have meaningful names beyond "in what context do they appear". I'm trying to follow pokegold's precedents for 100% label completion even with unused/unidentifiable variables.