Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve NPC trade labels and comments #493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SatoMew
Copy link
Contributor

@SatoMew SatoMew commented Feb 1, 2025

This PR partially amends #384 by correcting the information about the previously mentioned localization oversight and reworks the documentation of InGameTrade_CheckForTradeEvo a bit.

Should evolve_trade.asm be renamed to avoid confusion with EVOLVE_TRADE since the file is only for InGameTrade_CheckForTradeEvo?

@Rangi42 Rangi42 requested a review from dannye February 7, 2025 16:24
; This was fixed in Yellow.

; In Japanese Blue, TradeMons include a Graveler and a Haunter,
; both of which have Japanese names that start with "ご",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pokémon names use Katakana, so it is actually a "ゴ" 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I forgot to switch to katakana in the IME when I typed that in, thanks!

@Narishma-gb
Copy link
Contributor

Slightly off-topic, would you consider using constants in in_game_trades.asm ?
Trade text dialogs are indexed at wInGameTradeTextPointerTableIndex, and are used as raw numbers in DoInGameTradeDialogue.

; in game trade text pointers
; TradeTextPointersX indexes (see engine/events/in_game_trades.asm)
	const_def
	const TEXT_WANNA_TRADE ; 0
	const TEXT_NO_TRADE    ; 1
	const TEXT_WRONG_MON   ; 2
	const TEXT_THANKS      ; 3
	const TEXT_AFTER_TRADE ; 4

I used these constant names in Pokegreen, see https://github.com/Narishma-gb/pokegreen/blob/24ad50fa9c7295e7b2fd003a7b40386cc02a7d32/engine/events/in_game_trades.asm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants