Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate the /flat entry for compatibility #309

Merged
merged 3 commits into from
Mar 7, 2025
Merged

fix: separate the /flat entry for compatibility #309

merged 3 commits into from
Mar 7, 2025

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Mar 7, 2025

close #308

Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: 927f458

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-config-prettier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JounQin JounQin changed the title fix: separate the /flat entry for compatibility fix: separate the /flat entry for compatibility Mar 7, 2025
@JounQin JounQin merged commit eb56a5e into main Mar 7, 2025
13 checks passed
@JounQin JounQin deleted the fix/name branch March 7, 2025 09:35
@fisker
Copy link
Member

fisker commented Mar 7, 2025

Shouldn't it work if make name non-enumerable.

@JounQin
Copy link
Member Author

JounQin commented Mar 7, 2025

Shouldn't it work if make name non-enumerable.

Oh, I'm not sure about that, maybe I can give it a try, thanks!

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 8, 2025
| datasource | package                | from   | to     |
| ---------- | ---------------------- | ------ | ------ |
| npm        | eslint-config-prettier | 10.0.1 | 10.1.1 |


## [v10.1.1](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1011)

##### Patch Changes

-   [#309](prettier/eslint-config-prettier#309) [`eb56a5e`](prettier/eslint-config-prettier@eb56a5e) Thanks [@JounQin](https://github.com/JounQin)! - fix: separate the `/flat` entry for compatibility

    For flat config users, the previous `"eslint-config-prettier"` entry still works, but `"eslint-config-prettier/flat"` adds a new `name` property for [config-inspector](https://eslint.org/blog/2024/04/eslint-config-inspector/), we just can't add it for the default entry for compatibility.

    See also [#308](prettier/eslint-config-prettier#308)

    ```ts
    // before
    import eslintConfigPrettier from "eslint-config-prettier";

    // after
    import eslintConfigPrettier from "eslint-config-prettier/flat";
    ```


## [v10.1.0](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1010)

##### Minor Changes

-   [#306](prettier/eslint-config-prettier#306) [`56e2e34`](prettier/eslint-config-prettier@56e2e34) Thanks [@JounQin](https://github.com/JounQin)! - feat: migrate to exports field


## [v10.0.3](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1003)

##### Patch Changes

-   [#294](prettier/eslint-config-prettier#294) [`8dbbd6d`](prettier/eslint-config-prettier@8dbbd6d) Thanks [@FloEdelmann](https://github.com/FloEdelmann)! - feat: add name to config

-   [#280](prettier/eslint-config-prettier#280) [`cba5737`](prettier/eslint-config-prettier@cba5737) Thanks [@zanminkian](https://github.com/zanminkian)! - feat: add declaration file


## [v10.0.2](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1002)

##### Patch Changes

-   [#299](prettier/eslint-config-prettier#299) [`e750edc`](prettier/eslint-config-prettier@e750edc) Thanks [@Fdawgs](https://github.com/Fdawgs)! - chore(package): explicitly declare js module type
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 8, 2025
| datasource | package                | from   | to     |
| ---------- | ---------------------- | ------ | ------ |
| npm        | eslint-config-prettier | 10.0.1 | 10.1.1 |


## [v10.1.1](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1011)

##### Patch Changes

-   [#309](prettier/eslint-config-prettier#309) [`eb56a5e`](prettier/eslint-config-prettier@eb56a5e) Thanks [@JounQin](https://github.com/JounQin)! - fix: separate the `/flat` entry for compatibility

    For flat config users, the previous `"eslint-config-prettier"` entry still works, but `"eslint-config-prettier/flat"` adds a new `name` property for [config-inspector](https://eslint.org/blog/2024/04/eslint-config-inspector/), we just can't add it for the default entry for compatibility.

    See also [#308](prettier/eslint-config-prettier#308)

    ```ts
    // before
    import eslintConfigPrettier from "eslint-config-prettier";

    // after
    import eslintConfigPrettier from "eslint-config-prettier/flat";
    ```


## [v10.1.0](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1010)

##### Minor Changes

-   [#306](prettier/eslint-config-prettier#306) [`56e2e34`](prettier/eslint-config-prettier@56e2e34) Thanks [@JounQin](https://github.com/JounQin)! - feat: migrate to exports field


## [v10.0.3](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1003)

##### Patch Changes

-   [#294](prettier/eslint-config-prettier#294) [`8dbbd6d`](prettier/eslint-config-prettier@8dbbd6d) Thanks [@FloEdelmann](https://github.com/FloEdelmann)! - feat: add name to config

-   [#280](prettier/eslint-config-prettier#280) [`cba5737`](prettier/eslint-config-prettier@cba5737) Thanks [@zanminkian](https://github.com/zanminkian)! - feat: add declaration file


## [v10.0.2](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#1002)

##### Patch Changes

-   [#299](prettier/eslint-config-prettier#299) [`e750edc`](prettier/eslint-config-prettier@e750edc) Thanks [@Fdawgs](https://github.com/Fdawgs)! - chore(package): explicitly declare js module type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected top-level property "name"
2 participants