feat: instant bridge service #610
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikelle
reviewed
Feb 21, 2025
p2p/pkg/rpc/validator/service.go
Outdated
| @@ -273,30 +281,29 @@ func (s *Service) processEpoch(ctx context.Context, epoch uint64, epochTime int6 | |||
|
|
|||
| optedInSlots := make([]map[string]interface{}, 0) | |||
| for slot, info := range validators { | |||
| optedInSlots = append(optedInSlots, map[string]interface{}{ | |||
There was a problem hiding this comment.
Why is it more convenient to get notification for not opted in validators?
There was a problem hiding this comment.
In order to estimate the time we need the exact index of the slot in the epoch. So if we send just the opted in slots, we have to calculate the index of the slot in the epoch which was more complicated.
Other option is to put the start time of each slot in the notification. But I thought this is easier. Wdyt?
There was a problem hiding this comment.
We could add index/time here in the slot info: https://github.com/primev/mev-commit/blob/main/p2p/pkg/rpc/validator/service.go#L227
aloknerurkar
force-pushed
the
instant-bridge
branch
from
1c5af58 to
7c7a50e
Compare
added 23 commits
February 22, 2025 00:23
added 12 commits
February 27, 2025 18:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review