Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vn-acuvity-poc- Dependencies + Adding popup window support #65

Open
wants to merge 3 commits into
base: vn-acuvity-poc
Choose a base branch
from

Conversation

tanishq-acu
Copy link

@tanishq-acu tanishq-acu commented Jul 24, 2024

Added:

  1. Resolving dependencies
  2. LinkedPage to allow the agent to interact with popup windows and go back to previous context when the popup window is closed
  • This could potentially also work well with providing the ability to close the current focused tab to the agent in the future

These address issues #64 and #63

Testing:

  • Although the current test suite in the repository appears to be broken when you clone the repository, the number of passed/failed tests still remains the same, indicating no critical functionality has changed
  • Further, automated testing on the agent functionality with the prompt "Go to website and sign in to google with <google credentials/google credentials tool>" has been confirmed to work if you provide the agent with a way to enter some dummy credentials.

@tanishq-acu
Copy link
Author

@vnawrath @satyamsi from Acuvity asked me to tag you to take a look at this PR and provide feedback.

@vnawrath
Copy link
Contributor

Thank you for addressing the issues. I'll have to play with it a little bit to see if there are any edge cases or situations where the agent get's it wrong.
It's also unfortunate that the _ensure_page functionality is re-implemented in each of the implementations of the playwright plugin, so we might consider unifying this, and perhaps making this a general multi-page support.
Feel free to merge, since it addresses the issues you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants