Skip to content

Commit

Permalink
simpler builds
Browse files Browse the repository at this point in the history
  • Loading branch information
mkstoyanov committed Nov 20, 2024
1 parent 70eeebe commit edb280d
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 39 deletions.
37 changes: 1 addition & 36 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,36 +1 @@
Please review the [developer documentation](https://github.com/project-asgard/asgard/wiki/developing)
on the wiki of this project that contains help and requirements.

## Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with [a supported keyword](https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword).

## What type(s) of changes does this code introduce?
_Put an `x` in the boxes that apply._

- [ ] Bugfix
- [ ] New feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

### Does this introduce a breaking change?

- [ ] Yes
- [ ] No

## What systems has this change been tested on?

## Checklist

_Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code._

- [ ] this PR is up to date with current the current state of 'develop'
- [ ] code added or changed in the PR has been clang-formatted
- [ ] this PR adds tests to cover any new code, or to catch a bug that is being fixed
- [ ] documentation has been added (if appropriate)
# please include relevant information so the lead knows why this is needed
12 changes: 9 additions & 3 deletions .github/workflows/build-macos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ on:
push:
pull_request:
jobs:
build:
asgard:
strategy:
# float-only build is a rare case, no need to support
# osx-13 maybe overkill
matrix:
prec: [float, double, float\;double]
prec: [double, float\;double]
os: [macos-13, macos-14]
runs-on: ${{matrix.os}}
steps:
Expand All @@ -23,7 +25,11 @@ jobs:
run: cmake -E make_directory build
- name: Configure Default
working-directory: ${{runner.workspace}}/asgard/build
run: cmake -DCMAKE_BUILD_TYPE=Release -DASGARD_RECOMMENDED_DEFAULTS=ON -DASGARD_USE_PCH=ON -DASGARD_PRECISIONS=${{matrix.prec}} ../
run: cmake -DCMAKE_BUILD_TYPE=Release
-DASGARD_RECOMMENDED_DEFAULTS=ON
-DACCELERATE_NEW_LAPACK
-DASGARD_PRECISIONS=${{matrix.prec}}
../
- name: Build
working-directory: ${{runner.workspace}}/asgard/build
run: make -j VERBOSE=1
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build-ubuntu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
workflow_dispatch:
jobs:
asgard-core:
# no MPI/CUDA but on CPU with OpenBlas and HDF5
# some BALS is required, makes little sense to skip HDF5 (can't output anything)
strategy:
matrix:
prec: [float, double, float\;double]
Expand Down Expand Up @@ -35,6 +37,7 @@ jobs:
working-directory: ${{runner.workspace}}/asgard/build/Testing/Temporary
run: cat LastTest.log
asgard-mpi:
# basic MPI build using default settings
runs-on: ubuntu-22.04
steps:
- name: Git checkout
Expand Down Expand Up @@ -62,6 +65,7 @@ jobs:
working-directory: ${{runner.workspace}}/asgard/build/Testing/Temporary
run: cat LastTest.log
asgard-mkl:
# maybe an overkill but there are some differences between MKL and OpenBlas
runs-on: ubuntu-22.04
steps:
- name: Git checkout
Expand Down

0 comments on commit edb280d

Please sign in to comment.