fix: run pypi / docker upload from published draft releases (#2461)

Draft releases don't trigger the workflows (that's good!) but since they only Commit history before merge: * fix: run pypi upload from published draft releases * Fix broken task list markup in PR template * change docker workflow to build on release publish Co-authored-by: Richard Si <[email protected]>
psf · Aug 30, 2021 · 79575f3 · 79575f3
1 parent a8b4665
commit 79575f3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -18,9 +18,9 @@
     Tests are required for bugfixes and new features. Documentation changes
     are necessary for formatting and most enhancement changes. -->
 
-- [] Add a CHANGELOG entry if necessary?
-- [] Add / update tests if necessary?
-- [] Add new / update outdated documentation?
+- [ ] Add a CHANGELOG entry if necessary?
+- [ ] Add / update tests if necessary?
+- [ ] Add new / update outdated documentation?
 
 <!-- Just as a reminder, everyone in all psf/black spaces including PRs
      must follow the PSF Code of Conduct (link below).

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -5,7 +5,7 @@ on:
     branches:
       - "main"
   release:
-    types: created
+    types: [published]
 
 jobs:
   docker:

diff --git a/.github/workflows/pypi_upload.yml b/.github/workflows/pypi_upload.yml
@@ -2,7 +2,7 @@ name: pypi_upload
 
 on:
   release:
-    types: created
+    types: [published]
 
 jobs:
   build:
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,7 @@ name: pypi_upload @@
     on:
       release:
-        types: created
+        types: [published]
     jobs:
       build:
@@ Expand Down @@