Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.10-dev #2406

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Test on Python 3.10-dev #2406

merged 1 commit into from
Jul 28, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jul 28, 2021

Python 3.10 is currently in its last beta with a release candidate due next week (2021-08-02).

This PR tests 3.10-dev on GitHub Actions, currently Python 3.10.0-beta.4.


I put the versions in quotes in the yaml, because when 3.10 final is released and -dev is removed from 3.10-dev, quoteless 3.10 would evaluate to 3.1!

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Jul 28, 2021
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -24,7 +24,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10-dev"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The float rounding indicates what a fail 3.10 is :P

@cooperlees
Copy link
Collaborator

cooperlees commented Jul 28, 2021

Stoked we pass! Do we just avoid changing Pattern matching syntax today or we somehow understand it?

I wonder if anyone has created a repo that has Python Code that uses every python syntactical feature under the sun - If not, we should create said repo and put it into primers config ...

https://docs.python.org/3.10/whatsnew/3.10.html

This is scope creep and we will merge before caring about this - Was just interested ...

@cooperlees cooperlees merged commit 8ea641e into psf:main Jul 28, 2021
@hugovk hugovk deleted the add-3.10-dev branch July 28, 2021 14:51
@hugovk
Copy link
Contributor Author

hugovk commented Jul 28, 2021

Do we just avoid changing Pattern matching syntax today or we somehow understand it?

It's not yet supported, see #2242.

ichard26 pushed a commit that referenced this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants