Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze mypy version for CI (fixes #408) #409

Closed
wants to merge 2 commits into from
Closed

Freeze mypy version for CI (fixes #408) #409

wants to merge 2 commits into from

Conversation

cxong
Copy link
Contributor

@cxong cxong commented Jul 17, 2018

This freezes the version of mypy in the pip install command in .travis.yml and .appveyor.yml to the one in Pipfile.lock (0.600).

A better solution would be to get CI to use pipenv to install its dependencies, but I ran into issues setting that up for Travis CI; I'm not sure if pipenv currently works well in Travis CI. Haven't tried this for AppVeyor yet.

@coveralls
Copy link

coveralls commented Jul 17, 2018

Pull Request Test Coverage Report for Build 587

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.004%

Totals Coverage Status
Change from base Build 585: 0.0%
Covered Lines: 2619
Relevant Lines: 2728

💛 - Coveralls

@cxong cxong changed the title Freeze mypy version for Travis (fixes #408) Freeze mypy version for CI (fixes #408) Jul 17, 2018
@zsol
Copy link
Collaborator

zsol commented Jul 17, 2018

Thanks @cxong! Yep, this will make the builds pass, but it doesn't actually fix #408. I think we'll need to do both of

  1. use the pinned package versions for CI
  2. fix the actual type errors and bump the mypy version

What were the issues you ran into with pipenv + travis?

@zsol
Copy link
Collaborator

zsol commented Jul 18, 2018

I did 2. from above, so I'm going to close this out. If you want to, I'll be happy to accept PRs to use pinned package versions in CI, that will make sure this never happens again.

@zsol zsol closed this Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants