Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2492: Adding Information about PyInstaller Binaries #4545

Closed
wants to merge 2 commits into from

Conversation

RohitGavale
Copy link

Added information about PyInstaller Binaries. This is my first contribution for learning purpose.

@MeGaGiGaGon
Copy link
Collaborator

Thank you for your contribution. I've looked it over and have a couple comments:

You can create a link to another issue/pr by doing #, ie #2492. If you put something along the lines of "Fixes #2492" in your opening PR description, it will link the issue so it is automatically closed on merge. This also works if you edit the message after creation.

I read your changes and #2492, and sadly I don't think your current changes match what #2492 was asking for. According to the one place PyInstaller is mentioned in the docs the binaries are so that people can run black without having to install python. #2492 looks to be wanting more places in the documentation that say "Hey, we have PyInstaller binaries you can use if you don't have/want python". The best places to add those statements would probably be the installation section of the getting started page and the installation section of the readme

As cooperlees said in #2492, if you want to be more ambitious you could also make a dedicated docs section for all the different ways to install black, at least some of which were listed by cooperlees in #2492. I'm not sure if that list remains accurate since it has been two years.

@cooperlees
Copy link
Collaborator

I'm not sure if that list remains accurate since it has been two years.

They are all still valid from my quick re-read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants