-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid: DirectedGraph to basic flowchart #74
Conversation
This PR has been ready to merge but unfortunately I left it open as I thought I might be able to add a feature; that would be belong in another PR. |
279f2d5
to
4e475af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
A note on the commit message: Since this also initializes the mermaid
module, I'd like to mention that in the message. Typically I just do init; <other stuff
. So I'd recommend:
feat(mermaid): init; add `flowchart()`
37014c3
to
2bbc3e3
Compare
2bbc3e3
to
2dad8a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧙 ⚡
Closes #72
Thanks for the guidance coding this together in our Liveshare.