Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid: DirectedGraph to basic flowchart #74

Merged
merged 1 commit into from
May 28, 2023
Merged

Conversation

AustinArey
Copy link
Collaborator

@AustinArey AustinArey commented May 15, 2023

Closes #72

Thanks for the guidance coding this together in our Liveshare.

@AustinArey AustinArey changed the title Mermaid: basic flowchart Mermaid: DirectedGraph to basic flowchart May 15, 2023
@AustinArey
Copy link
Collaborator Author

AustinArey commented May 28, 2023

This PR has been ready to merge but unfortunately I left it open as I thought I might be able to add a feature; that would be belong in another PR.

@AustinArey AustinArey force-pushed the mermaid-flowchart branch from 279f2d5 to 4e475af Compare May 28, 2023 02:35
Copy link
Owner

@pskfyi pskfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

A note on the commit message: Since this also initializes the mermaid module, I'd like to mention that in the message. Typically I just do init; <other stuff. So I'd recommend:

feat(mermaid): init; add `flowchart()`

mermaid/test.md Outdated Show resolved Hide resolved
mermaid/example.ts Outdated Show resolved Hide resolved
mermaid/flowchart.ts Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@AustinArey AustinArey force-pushed the mermaid-flowchart branch 4 times, most recently from 37014c3 to 2bbc3e3 Compare May 28, 2023 03:00
@AustinArey AustinArey marked this pull request as ready for review May 28, 2023 03:05
@pskfyi pskfyi self-requested a review May 28, 2023 03:06
readme.md Outdated Show resolved Hide resolved
readme.md Show resolved Hide resolved
@AustinArey AustinArey force-pushed the mermaid-flowchart branch from 2bbc3e3 to 2dad8a7 Compare May 28, 2023 03:12
Copy link
Owner

@pskfyi pskfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙 ⚡

@pskfyi pskfyi merged commit bbb4fff into main May 28, 2023
@pskfyi pskfyi deleted the mermaid-flowchart branch May 28, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add utilities to render DirectedGraph as Mermaid chart
2 participants