Fix checking for alphanumeric characters using proper conversion to a void undefined behavior (and assert message with MSBuild) #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When I use font icons in the name of a dockable window, such as:
This allows me to display a window tab with an icon for better readability:
However, closing the application triggers an assertion error (with MSBuild) related to the isalnum function (observed in debug mode). The issue seems linked to undefined behavior caused by passing a char directly to isalnum, which expects an unsigned char (or EOF) as int.
Reference: cppreference.com on isalnum.
An example from cppreference.com suggests using
static_cast<unsigned char>
to pass achar
fromstd::string
toisalnum
.Stack Trace :
Steps to Reproduce (at least with MSBuild)