Fix the failing CI #661
Closed
Fix the failing CI #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
force-pushed
the
fix-storage-conf-not-exist
branch
6 times, most recently
from
aa4b5a9 to
35e87e7
Compare
mdellweg
reviewed
Sep 11, 2024
| @@ -2,6 +2,8 @@ ARG FROM_TAG="latest" | |||
| FROM pulp/base:${FROM_TAG} | |||
| # https://ryandaniels.ca/blog/docker-dockerfile-arg-from-arg-trouble/ | |||
|
|
|||
| RUN dnf -y install xz | |||
There was a problem hiding this comment.
It seems to be good practice not to leave any cache files around in any layer of the image.
Suggested change
| RUN dnf -y install xz | |
| RUN dnf -y install xz && dnf clean all |
Maybe it's even worth combining this with the dnf command ion line 25.
There was a problem hiding this comment.
Yeah, but still, the root cause of the problem has not been resolved. Neither writing to /usr/share/containers/storage.conf nor $HOME/.config/containers/storage.conf helped. It looks like the storage.conf file ceased to exist.
lubosmj
force-pushed
the
fix-storage-conf-not-exist
branch
from
35e87e7 to
7c73d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.