Fix syncing total count when using signed_only=True #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Oct 5, 2023
| if cv_unique in self.already_synced: | ||
| return | ||
|
|
||
| # Mark the collection version as being processed | ||
| self.already_synced.add(cv_unique) |
There was a problem hiding this comment.
What is this? Apart from eating a lot of memory?
There was a problem hiding this comment.
It is for the dependency sync. We don't want to re-process the same collection version that we have already synced. There is only like 50,000 collection versions so this set grows up to a few megabytes.
There was a problem hiding this comment.
Do we want to skip this when doing a full mirror sync anyway?
What if we do a bloom filter thing?
(Just a few thoughts...)
There was a problem hiding this comment.
Ok, I added an if check for adding a CV to the already-synced set.
There was a problem hiding this comment.
Sorry, this was asking on a tangent. Would you mind making it a separate change?
mdellweg
previously approved these changes
Oct 5, 2023
gerrod3
force-pushed
the
empty-signed-sync
branch
3 times, most recently
from
f237538 to
dcfaec8
Compare
gerrod3
force-pushed
the
empty-signed-sync
branch
from
dcfaec8 to
3a0e03b
Compare
mdellweg
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1608
https://issues.redhat.com/browse/AAH-2692