Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize tests #1693

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Modernize tests #1693

merged 1 commit into from
Dec 13, 2023

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Dec 5, 2023

No description provided.

@mdellweg mdellweg force-pushed the modern_tests branch 11 times, most recently from 0fbd319 to 7fa7fdf Compare December 8, 2023 13:47
@mdellweg mdellweg marked this pull request as ready for review December 8, 2023 13:47
@mdellweg mdellweg changed the title WIP Modernize some tests Dec 8, 2023
@mdellweg mdellweg enabled auto-merge (rebase) December 8, 2023 17:30
@mdellweg mdellweg changed the title Modernize some tests Modernize tests Dec 11, 2023
gerrod3
gerrod3 requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close are we now to fully removing pulp_smash?

pulp_ansible/tests/functional/api/collection/test_signatures.py Outdated Show resolved Hide resolved
pulp_ansible/tests/functional/api/collection/test_signatures.py Outdated Show resolved Hide resolved
setup.py
Comment on lines -21 to -24
extras_require={
"test": [
"coverage",
"dynaconf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this was being used by galaxy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If, so this is bad design to have them defined in two places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @pulp/galaxy

@mdellweg
Copy link
Member Author

How close are we now to fully removing pulp_smash?

There are still some tests to convert. Removing the v2 api & tests will be a big milestone. My impression is the last tests are also not the easiest...

@mdellweg mdellweg merged commit 9c44730 into pulp:main Dec 13, 2023
15 checks passed
@mdellweg mdellweg deleted the modern_tests branch December 13, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerrod3 gerrod3 gerrod3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdellweg @gerrod3