Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULP-203] Fix a regression in migration 0056 #2041

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mdellweg
Copy link
Member

Having more than one collection version in the system prevents the migration 0056 to run, because null as a value is not allowed to appear more than once.

We need to clean this up very careful, becuase on some systems the migration may have applied cleanly.

fixes #2040

@mdellweg
Copy link
Member Author

@netsandbox any chance you can confirm that this fixes your migration?

Having more than one collection version in the system prevents the
migration 0056 to run, because null as a value is not allowed to appear
more than once.

We need to clean this up very careful, becuase on some systems the
migration may have applied cleanly.

fixes pulp#2040
@mdellweg mdellweg force-pushed the 2040_regression_migration_0056 branch from 262e6e1 to f47c012 Compare November 22, 2024 12:18
@netsandbox
Copy link

@mdellweg I can confirm that this changes fixes the database migrations.

@mdellweg mdellweg enabled auto-merge (rebase) November 22, 2024 13:53
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spooky backport

@mdellweg mdellweg merged commit 15561b9 into pulp:main Nov 22, 2024
12 checks passed
Copy link

patchback bot commented Nov 22, 2024

Backport to 0.23: 💚 backport PR created

✅ Backport PR branch: patchback/backports/0.23/15561b943a50dae20947a0b6f04f8b399d71ccca/pr-2041

Backported as #2042

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration 0056 is failing
3 participants