Enable support for svn_parent_path in vhost directories #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak7340
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
|
|
bastelfreak
reviewed
Dec 12, 2023
deepak7340
force-pushed
the
svn-parent-path
branch
from
95e1fff
to
4439141
Compare
|
Hi team can you please review this ? |
|
Can you please adjust the test suite so that this is tested? These hashes are currently free-form which allow you to add a new item with minimal effort but at the cost of being super fragile because a typo would not be catch… At some point, we will probably add data types to constraint what can be passed, but without tests this will make this needed step more stressful. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)