Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setenvif.conf to follow upstream changes #2534

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Mar 14, 2024

This brings the file closer to the upstream contents as of

https://git.launchpad.net/ubuntu/+source/apache2/commit/debian/config-dir/mods-available/setenvif.conf?id=696485dab93b0a8de434f051e2b85134d342dc33

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@mpdude mpdude requested review from bastelfreak, ekohl, smortex and a team as code owners March 14, 2024 12:58
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitively not an "upsteam" change, but the custom config of ubuntu on top of the custom config of debian for mod_setenvif seems to match the example configuration of mod_dav upsteam:

https://svn.apache.org/viewvc/httpd/httpd/trunk/docs/conf/extra/httpd-dav.conf.in?revision=1915651&view=markup

So LGTM, but there are a few more entries that seems to be incorrect and that we can sync with upsteam. I added in-line comments to them.

templates/mod/setenvif.conf.epp Outdated Show resolved Hide resolved
templates/mod/setenvif.conf.epp Outdated Show resolved Hide resolved
templates/mod/setenvif.conf.epp Show resolved Hide resolved
mpdude and others added 2 commits March 15, 2024 22:14
Co-authored-by: Romain Tartière <[email protected]>
Co-authored-by: Romain Tartière <[email protected]>
@@ -18,17 +18,11 @@ BrowserMatch "JDK/1\.0" force-response-1.0
BrowserMatch "Microsoft Data Access Internet Publishing Provider" redirect-carefully
BrowserMatch "MS FrontPage" redirect-carefully
BrowserMatch "^WebDrive" redirect-carefully
BrowserMatch "^WebDAVFS/1.[0123]" redirect-carefully
BrowserMatch "^gnome-vfs/1.0" redirect-carefully
BrowserMatch "^WebDAVFS/1\.[012]" redirect-carefully

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it on purpose that 1.3 was dropped here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants