Skip to content

Commit

Permalink
(MAINT) Disable new Rspec/RemoveConst cop
Browse files Browse the repository at this point in the history
Following the recent introduction of a new cop in Rubocop,
Rspec/RemoveConst, our CI has started failing. It seems like this rule
is being enforced as a good practice to avoid buggy debug information
but no real alternative is being offered.

This commit disables the cop to allow the CI to continue working. Here
are the discussions that led to the creation of the rule:
rubocop/rubocop-rspec#1748
rubocop/rubocop-rspec#1749
  • Loading branch information
LukasAud committed Jan 9, 2024
1 parent e0a0bb1 commit b246ecb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec/unit/adapters_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def context_double(options = {})
describe '#setup_puppet' do
describe 'when managing the facter_implementation' do
after do
Object.send(:remove_const, :FacterImpl) if defined? FacterImpl
Object.send(:remove_const, :FacterImpl) if defined? FacterImpl # rubocop:disable RSpec/RemoveConst
end

it 'uses facter as default implementation' do
Expand Down

0 comments on commit b246ecb

Please sign in to comment.