Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Disable new Rspec/RemoveConst cop #98

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

LukasAud
Copy link

@LukasAud LukasAud commented Jan 9, 2024

Following the recent introduction of a new cop in Rubocop, Rspec/RemoveConst, our CI has started failing. It seems like this rule is being enforced as a good practice to avoid buggy debug information but no real alternative is being offered.

This commit disables the cop to allow the CI to continue working. Here are the discussions that led to the creation of the rule:
rubocop/rubocop-rspec#1748
rubocop/rubocop-rspec#1749

Following the recent introduction of a new cop in Rubocop,
Rspec/RemoveConst, our CI has started failing. It seems like this rule
is being enforced as a good practice to avoid buggy debug information
but no real alternative is being offered.

This commit disables the cop to allow the CI to continue working. Here
are the discussions that led to the creation of the rule:
rubocop/rubocop-rspec#1748
rubocop/rubocop-rspec#1749
@LukasAud LukasAud requested review from bastelfreak and a team as code owners January 9, 2024 11:41
@jordanbreen28 jordanbreen28 merged commit 9983741 into main Jan 9, 2024
8 checks passed
@jordanbreen28 jordanbreen28 deleted the MAINT-Disable_new_removeconst_cop branch January 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants