Review formKey calculation for data validation cache #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With equally valued fields, the same key could be produced leading to misvalidations from the cache
|
Fix added in commit ae9b3ea. Couldn't merge directly due to conflicts. Sorry for the long delay (!) |
|
@jrivard Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a new user form having two checkboxes (one required and the other optional), I noticed that ticking one checkbox or the other at times bypassed the required field check, letting form submission — it must be noted that I'm working on a version with has #310 merged in.
This fix adds field names to the validation cache data, avoiding potentially equal field values to trigger misvalidations.