-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Configuration Parameter for OIDC with Auth0, fix for AD-Schema Import in AD #624
Open
fbuchmeier-abi
wants to merge
15
commits into
pwm-project:master
Choose a base branch
from
fbuchmeier-abi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge in OSSC/pwm-project-pwm from develop to master * commit 'c5b6306a0195a71c7714dfc0f946d3cfae861c81': fixed "invalid" DN error on importing schema into MS Active Directory added missing class simplified method updated labels added option to send either POST or GET requests to oauth userinfo endpoint simplified GET requests for userinfo endpoint quick fix for GET request on userinfo endpoint
Merge in OSSC/pwm-project-pwm from develop to master * commit 'e05ab2b2ea599c005b7a5202956c7a26e6e597d9': Removed obsolete debug output Returning new password as per https://www.pwm-project.org/pwm/public/reference/rest.jsp#rest-setpassword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
you can find the following changes in this PR:
(1) I've added a new configuration parameter in the OIDC config
HttpMethod
that can be set to POST (default) and GET for the UserInfo endpoint.This is because some OIDC providers like Auth0 require a GET request instead of a POST request to obtain data from the userinfo endpoint (see the User Profile API Doc for more details).
(2) To make OIDC logins work with the refactoring in 2.1.0 branch again, I've also had to update the PwmResponse.java to again work with external redirects. As far as I understand, in 2.0.0 all calls to the redirect response method were made with the baseUrl already added to the redirect target. Now, the baseUrl is conditionally added inside the method, which breaks external redirects like the ones to an OIDC sign in URL. The result in this case was
/pwmhttps://login.auth0...
which will obviously not work. In addition to checking for the presence of the baseUrl, i've also added a check to see it the redirect includes a protocol (http:// or https://) and in this case, skip adding the baseUrl in front of the redirect target.Also, the settings lookup in the OIDC auth had to be updated to
getAppConfig
instead ofgetDomainConfig
, otherwise it will fail with the following error:(3) In addition to this, I've updated the provided AD-schema.ldif example to actually work with Microsoft Active Directory. As far as my tests went, AD fails with a schema validation as long as the leading whitespaces after
dn:
are present.Please let me know if you have any questions or feedback I should include in the PR.
Best Regards,
Florian.