Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Change codacy to default off #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

liamhuber
Copy link
Member

With ruff and black across the whole repo (excl. docs) by default in the next actions release, I don't see a need to keep running codacy. From what I understand it may be useful if we want to apply additional screenings for things like cryptographic or license compliance, but we're not really leveraging any of that afaik. I'm happy to keep the functionality available, but I'm inclined to make it on-request instead of always there.

Thoughts?

@liamhuber liamhuber changed the title [major] Change codacy to default off [minor] Change codacy to default off Jan 8, 2025
Copy link
Contributor

@XzzX XzzX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a manual on-demand trigger, if that is possible with github, would be best.

@liamhuber
Copy link
Member Author

I think a manual on-demand trigger, if that is possible with github, would be best.

Triggers are not something we can handle here, that's up to the downstream repos, but it is certainly possible. What's up to us then to structure the reusable workflows in a way that is useful for those repos. I think we've already got that though, since the codacy stuff is encapsulated in the tests-and-coverage.yml reusable workflow, which is in turn called by the master push-pull.yml workflow. So having it default off works fine for everyone calling

name: Push-Pull

on:
  push:
    branches: [ main ]
  pull_request:

jobs:
  pyiron:
    uses: pyiron/actions/.github/workflows/[email protected]
    secrets: inherit

And downstream repos are further already free to additionally define something like

name: Do Codacy

on: workflow_dispatch

jobs:
 codacy:
   uses: pyiron/actions/.github/workflows/[email protected]
   secrets: inherit
   with:
     do-codacy: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants