-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add executorlib container #589
Conversation
@niklassiemer, I guess this
Just needs to be replaced with the relevant I suggest adopting one of the two suggestions I made to tighten up the interface, but if you hate both I can live with it as-is and otherwise once the tests are passing I'm happy here. Thanks for taking care of it! |
Thanks for the feedback! I was actually using the tests here to figure out what needs to be changed in the tests xD and I was thinking to add Indeed, I would like to have #Edit |
Co-authored-by: Liam Huber <[email protected]>
Funny enough all my code will be gone and you did the full work after all xD |
I should not try these things on mobile xD do we want to maintain downwards compatibility to older versions of executorlib? Otherwise I would need to target the executorlib update branch I suppose :) |
Bumps [executorlib](https://github.com/pyiron/executorlib) from 0.0.10 to 0.2.0. - [Release notes](https://github.com/pyiron/executorlib/releases) - [Commits](pyiron/executorlib@executorlib-0.0.10...executorlib-0.2.0) --- updated-dependencies: - dependency-name: executorlib dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
main code shoule be independent of executorlib version
Dependabot/pip/executorlib 0.2.0
@liamhuber I do not know why the coveralls/codacy is failing - is it related to some hickups (I saw a comment of Jan on another PR but I do not remember where and I am not sure if this is related). |
closes #584