-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] separate drawing cell for plotly #187
Conversation
WalkthroughThe recent update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
structuretoolkit/visualize.py (1)
Line range hint
215-215
: Consider usingimportlib.util.find_spec
for conditional imports ofplotly
.+ from importlib.util import find_spec + if find_spec("plotly"): + import plotly.express as px + import plotly.graph_objects as go
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- structuretoolkit/visualize.py (2 hunks)
Additional Context Used
Ruff (4)
structuretoolkit/visualize.py (4)
169-169: Undefined name
get_cell
172-172: Undefined name
px
175-175: Undefined name
go
215-215:
plotly.graph_objects
imported but unused; consider usingimportlib.util.find_spec
to test for availability
Additional comments not posted (1)
structuretoolkit/visualize.py (1)
236-236
: Integration of_draw_box_plotly
looks good.Ensure that the import issues in
_draw_box_plotly
are resolved as they affect this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- structuretoolkit/visualize.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- structuretoolkit/visualize.py
I need this function to be separated for this PR
Summary by CodeRabbit