Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] separate drawing cell for plotly #187

Merged
merged 6 commits into from
May 20, 2024
Merged

[minor] separate drawing cell for plotly #187

merged 6 commits into from
May 20, 2024

Conversation

samwaseda
Copy link
Member

@samwaseda samwaseda commented May 19, 2024

I need this function to be separated for this PR

Summary by CodeRabbit

  • New Features
    • Introduced box plot visualization using Plotly in the app.

@samwaseda samwaseda requested a review from jan-janssen as a code owner May 19, 2024 16:46
Copy link

coderabbitai bot commented May 19, 2024

Walkthrough

The recent update to the structuretoolkit module enhances the visualization capabilities by adding a new function, _draw_box_plotly, to draw box plots using Plotly. This function streamlines the code by generating lines for the box skeleton and updating trace colors. Consequently, the _plot3d_plotly function now leverages _draw_box_plotly for box plotting, resulting in a more organized and maintainable code structure.

Changes

File Change Summary
structuretoolkit/visualize.py Added _draw_box_plotly to draw box plots using Plotly and updated _plot3d_plotly to use this function.

🐇
In the world of plots and lines,
A new function brightly shines.
Boxes drawn with Plotly's grace,
Simplified code, a cleaner space.
Visuals now, a joy to see,
Thanks to structuretoolkit's spree!
🌟📊


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (1)
structuretoolkit/visualize.py (1)

Line range hint 215-215: Consider using importlib.util.find_spec for conditional imports of plotly.

+ from importlib.util import find_spec
+ if find_spec("plotly"):
+     import plotly.express as px
+     import plotly.graph_objects as go
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 696fd52 and 5675ead.
Files selected for processing (1)
  • structuretoolkit/visualize.py (2 hunks)
Additional Context Used
Ruff (4)
structuretoolkit/visualize.py (4)

169-169: Undefined name get_cell


172-172: Undefined name px


175-175: Undefined name go


215-215: plotly.graph_objects imported but unused; consider using importlib.util.find_spec to test for availability

Additional comments not posted (1)
structuretoolkit/visualize.py (1)

236-236: Integration of _draw_box_plotly looks good.

Ensure that the import issues in _draw_box_plotly are resolved as they affect this function.

structuretoolkit/visualize.py Outdated Show resolved Hide resolved
@samwaseda samwaseda changed the title separate drawing cell for plotly [minor] separate drawing cell for plotly May 20, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 5675ead and 29f5eea.
Files selected for processing (1)
  • structuretoolkit/visualize.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • structuretoolkit/visualize.py

@samwaseda samwaseda merged commit 631eda8 into main May 20, 2024
13 of 15 checks passed
@samwaseda samwaseda deleted the separate_draw_box branch May 20, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants