Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crc32c #4789

Merged
merged 7 commits into from
May 24, 2024
Merged

Add crc32c #4789

merged 7 commits into from
May 24, 2024

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented May 23, 2024

Description

This PR adds the crc32c package and closes #4787. crc32c is a required dependency for the upcoming version 3 for Zarr.

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

Additional context

xref: zarr-developers/zarr-python#1903

@agriyakhetarpal
Copy link
Member Author

The logs are reporting a ModuleNotFound error for import crc32c, and there is no error trace. Maybe I need to do import crc32c inside @run_in_pyodide(packages=["crc32c"])? I just pushed f2d1cdf, let me see if that fixes it.

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The pytest is complaining about the NameError: name 'as_individual_bytes' is not defined.

@agriyakhetarpal
Copy link
Member Author

The tests should pass now, thanks, @ryanking13! I guess @run_in_pyodide is sandboxed from the rest of the code or something – I moved as_individual_bytes() to inside the test so that it can be accessed by test_piece_by_piece directly. Ready for review/merging.

@hoodmane
Copy link
Member

Thanks!

@hoodmane hoodmane merged commit 15eb1ae into pyodide:main May 24, 2024
28 of 30 checks passed
@agriyakhetarpal agriyakhetarpal deleted the recipe/crc32c branch May 24, 2024 14:58
@agriyakhetarpal agriyakhetarpal mentioned this pull request Nov 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crc32c
3 participants