-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to set zip compression level #547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90cc108
to
dd525f9
Compare
dd525f9
to
672f9b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 92.07% 92.11% +0.03%
==========================================
Files 22 22
Lines 1553 1572 +19
Branches 285 286 +1
==========================================
+ Hits 1430 1448 +18
Misses 74 74
- Partials 49 50 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
519d728
to
85721f9
Compare
mayeut
reviewed
Mar 4, 2025
eabf8c4
to
8a84867
Compare
while a bit more verbose, it's also much clearer.
Thanks @oraluben |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--zip-compression-level
andAUDITWHEEL_ZIP_COMPRESSION_LEVEL
env to specify zip compression level.This PR do not change the default level.
Part of #545.
As in #545 (comment), we don't want to alter the default compress level. However I do want to add this argument to have the ability to change it.
I'm not very sure about the best place to add test for this.