Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to set zip compression level #547

Merged
merged 8 commits into from
Mar 8, 2025

Conversation

oraluben
Copy link
Contributor

@oraluben oraluben commented Feb 23, 2025

Add --zip-compression-level and AUDITWHEEL_ZIP_COMPRESSION_LEVEL env to specify zip compression level.

This PR do not change the default level.

Part of #545.
As in #545 (comment), we don't want to alter the default compress level. However I do want to add this argument to have the ability to change it.

I'm not very sure about the best place to add test for this.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.11%. Comparing base (b01e842) to head (a08481f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/auditwheel/tools.py 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   92.07%   92.11%   +0.03%     
==========================================
  Files          22       22              
  Lines        1553     1572      +19     
  Branches      285      286       +1     
==========================================
+ Hits         1430     1448      +18     
  Misses         74       74              
- Partials       49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oraluben oraluben changed the title chore: Add argument and env to specific compress level feat: Add argument and env to specific compress level Feb 23, 2025
@mayeut mayeut changed the title feat: Add argument and env to specific compress level feat: add option to set zip compression level Mar 8, 2025
@mayeut mayeut merged commit 0c1b26b into pypa:main Mar 8, 2025
13 of 14 checks passed
@mayeut
Copy link
Member

mayeut commented Mar 8, 2025

Thanks @oraluben

@oraluben oraluben deleted the custom-zip-level branch March 8, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants