Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove python 3.6 from tests and PyPI classifiers #811

Merged
merged 4 commits into from
Feb 14, 2022
Merged

remove python 3.6 from tests and PyPI classifiers #811

merged 4 commits into from
Feb 14, 2022

Conversation

cs01
Copy link
Member

@cs01 cs01 commented Feb 14, 2022 •
edited
Loading

  • I have added an entry to docs/changelog.md

Summary of changes

  • Python 3.6 has reached its end of life and is therefore being removed from CI tests
  • Fix windows encoding issue when pip fails to install a package
  • Upgrade black to first non-beta release 🎉
  • Unit tests now pass, which unblocks other PRs from landing. Maintainers (@gaborbernat @uranusjr ): From now on let's please keep the CI tests green so we have a clear testing signal on all PRs, and avoid committing broken code on top of broken code.

Test plan

Tested by running

nox -s tests-3.10

@cs01 cs01 force-pushed the cs01/remove-python-3.6 branch from 2e77fdc to a7fa996 Compare February 14, 2022 06:29
@cs01 cs01 merged commit b467994 into main Feb 14, 2022
@cs01 cs01 deleted the cs01/remove-python-3.6 branch February 14, 2022 06:55
@cs01 cs01 mentioned this pull request Feb 18, 2022
Closed
@uranusjr uranusjr mentioned this pull request Apr 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cs01