Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX use safe_getattr instead of getattr for Python 3.9 compat #11883

Closed
wants to merge 7 commits into from
Closed

FIX use safe_getattr instead of getattr for Python 3.9 compat #11883

wants to merge 7 commits into from

Conversation

glemaitre
Copy link

@glemaitre glemaitre commented Jan 29, 2024 •
edited
Loading

closes #11872

Use safe_getattr instead of getattr that fails with Python 3.9

TODO:

  • add non-regression test
  • create a changelog entry
  • add name in AUTHORS

@glemaitre glemaitre marked this pull request as draft January 29, 2024 18:05
@glemaitre glemaitre marked this pull request as ready for review January 29, 2024 18:38
@glemaitre glemaitre mentioned this pull request Jan 29, 2024
Closed
@bluetech
Copy link
Member

Thanks @glemaitre, this is a duplicate of #11879 so I'll close this one.

@bluetech bluetech closed this Jan 29, 2024
@glemaitre
Copy link
Author

Whoops sorry for that. I did not see the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: pytest.raises(HTTPError, match="...") breaks on Python 3.9 + pytest 8.0
2 participants
@glemaitre @bluetech