assorted code updates and f string migrations #12017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
ronny-ruff-upgrade
branch
4 times, most recently
from
f699e64 to
fd3ee18
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
The-Compiler
previously requested changes
Jun 21, 2024
RonnyPfannschmidt
force-pushed
the
ronny-ruff-upgrade
branch
from
77d991c to
7a30d30
Compare
nicoddemus
approved these changes
Jul 8, 2024
RonnyPfannschmidt
force-pushed
the
ronny-ruff-upgrade
branch
from
a2bb28b to
5e7f914
Compare
nicoddemus
reviewed
Jul 19, 2024
testing/test_junitxml.py
Outdated
| node = dom.find_first_by_tag("testsuite") | ||
| timestamp = datetime.strptime(node["timestamp"], "%Y-%m-%dT%H:%M:%S.%f%z") | ||
| node = dom.get_first_by_tag("testsuite") | ||
| print(node["timestamp"]) |
Co-authored-by: Bruno Oliveira <[email protected]>
RonnyPfannschmidt
force-pushed
the
ronny-ruff-upgrade
branch
from
124d9cc to
43e7011
Compare
|
@RonnyPfannschmidt can you fix the conflicts and perhaps go ahead and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bunch of changes i collected as i wanted to start redoing #10997
depends on #12501