-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #12122
Spelling #12122
Changes from all commits
77647e4
8fe62f6
a7abe2c
3ff72df
f016f51
7484a84
4b16fb6
de585d1
a045234
d414d4f
a0b1f52
13bfc38
bf1103a
e6e06e2
34060ef
ab8cc1f
ef9b183
05b212a
6ed10f4
fa75c3f
4bff7d5
35533bd
d6cc4d3
3f6acbb
fa1e25d
5694d5a
82fb1dc
8a66f76
e721a20
482d011
779cdd7
5122cf8
fcfb850
7bf1831
5c1fda8
dc50ab5
aa2cb8b
1af8e1a
ad75673
a6be7a9
158b02f
a75aeed
6b3939e
22936ed
c8e4d6c
375e516
ce3c994
3327c2c
c6d8e77
c296571
0ebd18b
2dcfe26
4585959
16a1cc0
fe8e038
ef7ed91
faa2f2e
d372ff2
2a12477
ea949ce
57f9adc
07268b5
90a8c4e
8406e52
033dc5f
0fd50b8
da213cf
6414d1a
0b0ce2d
cfcd16f
b9176fa
adbe684
607cc88
eb387a1
a72f482
c20f544
4988031
d219472
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -181,7 +181,7 @@ Bug fixes: | |
partially failed (finalizers would not always be called before) | ||
|
||
- fix issue320 - fix class scope for fixtures when mixed with | ||
module-level functions. Thanks Anatloy Bubenkoff. | ||
module-level functions. Thanks Anatoly Bubenkoff. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This matches other instances of what I have to presume is the same entity. |
||
|
||
- you can specify "-q" or "-qq" to get different levels of "quieter" | ||
reporting (thanks Katarzyna Jachim) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,7 +83,7 @@ holger krekel | |
Thanks Ralph Schmitt for the precise failure example. | ||
|
||
- fix issue244 by implementing special index for parameters to only use | ||
indices for paramentrized test ids | ||
indices for parametrized test ids | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there's an amusing thing elsewhere about a serious of variations of this word, but this isn't one of them... |
||
|
||
- fix issue287 by running all finalizers but saving the exception | ||
from the first failing finalizer and re-raising it so teardown will | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ holger krekel | |
- cleanup setup.py a bit and specify supported versions. Thanks Jurko | ||
Gospodnetic for the PR. | ||
|
||
- change XPASS colour to yellow rather then red when tests are run | ||
- change XPASS colour to yellow rather than red when tests are run | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. technically this is grammatical, but most spell checkers have been able to flag rudimentary grammar errors, so there are a handful of fixes for things like this... |
||
with -v. | ||
|
||
- fix issue473: work around mock putting an unbound method into a class | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some projects don't like changing changelogs. Happy to drop as desired. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,7 +60,7 @@ Improvements | |
- `#11311 <https://github.com/pytest-dev/pytest/issues/11311>`_: When using ``--override-ini`` for paths in invocations without a configuration file defined, the current working directory is used | ||
as the relative directory. | ||
|
||
Previoulsy this would raise an :class:`AssertionError`. | ||
Previously this would raise an :class:`AssertionError`. | ||
|
||
|
||
- `#11475 <https://github.com/pytest-dev/pytest/issues/11475>`_: :ref:`--import-mode=importlib <import-mode-importlib>` now tries to import modules using the standard import mechanism (but still without changing :py:data:`sys.path`), falling back to importing modules directly only if that fails. | ||
|
@@ -1303,7 +1303,7 @@ Deprecations | |
``__init__`` method, they should take ``**kwargs``. See | ||
:ref:`uncooperative-constructors-deprecated` for details. | ||
|
||
Note that a deprection warning is only emitted when there is a conflict in the | ||
Note that a deprecation warning is only emitted when there is a conflict in the | ||
arguments pytest expected to pass. This deprecation was already part of pytest | ||
7.0.0rc1 but wasn't documented. | ||
|
||
|
@@ -1345,7 +1345,7 @@ Breaking Changes | |
- `#7259 <https://github.com/pytest-dev/pytest/issues/7259>`_: The :ref:`Node.reportinfo() <non-python tests>` function first return value type has been expanded from `py.path.local | str` to `os.PathLike[str] | str`. | ||
|
||
Most plugins which refer to `reportinfo()` only define it as part of a custom :class:`pytest.Item` implementation. | ||
Since `py.path.local` is an `os.PathLike[str]`, these plugins are unaffacted. | ||
Since `py.path.local` is an `os.PathLike[str]`, these plugins are unaffected. | ||
|
||
Plugins and users which call `reportinfo()`, use the first return value and interact with it as a `py.path.local`, would need to adjust by calling `py.path.local(fspath)`. | ||
Although preferably, avoid the legacy `py.path.local` and use `pathlib.Path`, or use `item.location` or `item.path`, instead. | ||
|
@@ -1853,7 +1853,7 @@ Bug Fixes | |
the ``tmp_path``/``tmpdir`` fixture). Now the directories are created with | ||
private permissions. | ||
|
||
pytest used to silently use a pre-existing ``/tmp/pytest-of-<username>`` directory, | ||
pytest used to silently use a preexisting ``/tmp/pytest-of-<username>`` directory, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both flavors were preexisting in this repository :) |
||
even if owned by another user. This means another user could pre-create such a | ||
directory and gain control of another user's temporary directory. Now such a | ||
condition results in an error. | ||
|
@@ -2580,7 +2580,7 @@ Features | |
also changes ``sys.modules`` as a side-effect), which works but has a number of drawbacks, like requiring test modules | ||
that don't live in packages to have unique names (as they need to reside under a unique name in ``sys.modules``). | ||
|
||
``--import-mode=importlib`` uses more fine grained import mechanisms from ``importlib`` which don't | ||
``--import-mode=importlib`` uses more fine-grained import mechanisms from ``importlib`` which don't | ||
require pytest to change ``sys.path`` or ``sys.modules`` at all, eliminating much of the drawbacks | ||
of the previous mode. | ||
|
||
|
@@ -2597,7 +2597,7 @@ Improvements | |
------------ | ||
|
||
- :issue:`4375`: The ``pytest`` command now suppresses the ``BrokenPipeError`` error message that | ||
is printed to stderr when the output of ``pytest`` is piped and and the pipe is | ||
is printed to stderr when the output of ``pytest`` is piped and the pipe is | ||
closed by the piped-to program (common examples are ``less`` and ``head``). | ||
|
||
|
||
|
@@ -2899,7 +2899,7 @@ Breaking Changes | |
This hook has been marked as deprecated and not been even called by pytest for over 10 years now. | ||
|
||
|
||
- :issue:`6673`: Reversed / fix meaning of "+/-" in error diffs. "-" means that sth. expected is missing in the result and "+" means that there are unexpected extras in the result. | ||
- :issue:`6673`: Reversed / fix meaning of "+/-" in error diffs. "-" means that something expected is missing in the result and "+" means that there are unexpected extras in the result. | ||
|
||
|
||
- :issue:`6737`: The ``cached_result`` attribute of ``FixtureDef`` is now set to ``None`` when | ||
|
@@ -4504,7 +4504,7 @@ Bug Fixes | |
Improved Documentation | ||
---------------------- | ||
|
||
- :issue:`4974`: Update docs for ``pytest_cmdline_parse`` hook to note availability liminations | ||
- :issue:`4974`: Update docs for ``pytest_cmdline_parse`` hook to note availability limitations | ||
|
||
|
||
|
||
|
@@ -6362,7 +6362,7 @@ Features | |
Bug Fixes | ||
--------- | ||
|
||
- Fix hanging pexpect test on MacOS by using flush() instead of wait(). | ||
- Fix hanging pexpect test on macOS by using flush() instead of wait(). | ||
(:issue:`2022`) | ||
|
||
- Fix restoring Python state after in-process pytest runs with the | ||
|
@@ -6410,7 +6410,7 @@ Trivial/Internal Changes | |
------------------------ | ||
|
||
- Show a simple and easy error when keyword expressions trigger a syntax error | ||
(for example, ``"-k foo and import"`` will show an error that you can not use | ||
(for example, ``"-k foo and import"`` will show an error that you cannot use | ||
the ``import`` keyword in expressions). (:issue:`2953`) | ||
|
||
- Change parametrized automatic test id generation to use the ``__name__`` | ||
|
@@ -8186,7 +8186,7 @@ time or change existing behaviors in order to make them less surprising/more use | |
one will also have a "reprec" attribute with the recorded events/reports. | ||
|
||
- fix monkeypatch.setattr("x.y", raising=False) to actually not raise | ||
if "y" is not a pre-existing attribute. Thanks Florian Bruhin. | ||
if "y" is not a preexisting attribute. Thanks Florian Bruhin. | ||
|
||
- fix issue741: make running output from testdir.run copy/pasteable | ||
Thanks Bruno Oliveira. | ||
|
@@ -8242,7 +8242,7 @@ time or change existing behaviors in order to make them less surprising/more use | |
|
||
- fix issue854: autouse yield_fixtures defined as class members of | ||
unittest.TestCase subclasses now work as expected. | ||
Thannks xmo-odoo for the report and Bruno Oliveira for the PR. | ||
Thanks xmo-odoo for the report and Bruno Oliveira for the PR. | ||
|
||
- fix issue833: --fixtures now shows all fixtures of collected test files, instead of just the | ||
fixtures declared on the first one. | ||
|
@@ -8346,7 +8346,7 @@ time or change existing behaviors in order to make them less surprising/more use | |
github. See https://pytest.org/en/stable/contributing.html . | ||
Thanks to Anatoly for pushing and initial work on this. | ||
|
||
- fix issue650: new option ``--docttest-ignore-import-errors`` which | ||
- fix issue650: new option ``--doctest-ignore-import-errors`` which | ||
will turn import errors in doctests into skips. Thanks Charles Cloud | ||
for the complete PR. | ||
|
||
|
@@ -8534,7 +8534,7 @@ time or change existing behaviors in order to make them less surprising/more use | |
- cleanup setup.py a bit and specify supported versions. Thanks Jurko | ||
Gospodnetic for the PR. | ||
|
||
- change XPASS colour to yellow rather then red when tests are run | ||
- change XPASS colour to yellow rather than red when tests are run | ||
with -v. | ||
|
||
- fix issue473: work around mock putting an unbound method into a class | ||
|
@@ -8707,15 +8707,15 @@ time or change existing behaviors in order to make them less surprising/more use | |
Thanks Ralph Schmitt for the precise failure example. | ||
|
||
- fix issue244 by implementing special index for parameters to only use | ||
indices for paramentrized test ids | ||
indices for parametrized test ids | ||
|
||
- fix issue287 by running all finalizers but saving the exception | ||
from the first failing finalizer and re-raising it so teardown will | ||
still have failed. We reraise the first failing exception because | ||
it might be the cause for other finalizers to fail. | ||
|
||
- fix ordering when mock.patch or other standard decorator-wrappings | ||
are used with test methods. This fixues issue346 and should | ||
are used with test methods. This fixes issue346 and should | ||
help with random "xdist" collection failures. Thanks to | ||
Ronny Pfannschmidt and Donald Stufft for helping to isolate it. | ||
|
||
|
@@ -8972,7 +8972,7 @@ Bug fixes: | |
partially failed (finalizers would not always be called before) | ||
|
||
- fix issue320 - fix class scope for fixtures when mixed with | ||
module-level functions. Thanks Anatloy Bubenkoff. | ||
module-level functions. Thanks Anatoly Bubenkoff. | ||
|
||
- you can specify "-q" or "-qq" to get different levels of "quieter" | ||
reporting (thanks Katarzyna Jachim) | ||
|
@@ -9394,7 +9394,7 @@ Bug fixes: | |
unexpected exceptions | ||
- fix issue47: timing output in junitxml for test cases is now correct | ||
- fix issue48: typo in MarkInfo repr leading to exception | ||
- fix issue49: avoid confusing error when initizaliation partially fails | ||
- fix issue49: avoid confusing error when initialization partially fails | ||
- fix issue44: env/username expansion for junitxml file path | ||
- show releaselevel information in test runs for pypy | ||
- reworked doc pages for better navigation and PDF generation | ||
|
@@ -9519,7 +9519,7 @@ Bug fixes: | |
collection-before-running semantics were not | ||
setup as with pytest 1.3.4. Note, however, that | ||
the recommended and much cleaner way to do test | ||
parametraization remains the "pytest_generate_tests" | ||
parameterization remains the "pytest_generate_tests" | ||
mechanism, see the docs. | ||
|
||
2.0.0 (2010-11-25) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -427,7 +427,7 @@ Now :class:`~pytest.Class` collects the test methods directly. | |
Most plugins which reference ``Instance`` do so in order to ignore or skip it, | ||
using a check such as ``if isinstance(node, Instance): return``. | ||
Such plugins should simply remove consideration of ``Instance`` on pytest>=7. | ||
However, to keep such uses working, a dummy type has been instanted in ``pytest.Instance`` and ``_pytest.python.Instance``, | ||
However, to keep such uses working, a dummy type has been instanced in ``pytest.Instance`` and ``_pytest.python.Instance``, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I couldn't be certain that this shouldn't be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both work I think? |
||
and importing it emits a deprecation warning. This was removed in pytest 8. | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ If you used older version of the ``py`` distribution (which | |
included the py.test command line tool and Python name space) | ||
you accessed helpers and possibly collection classes through | ||
the ``py.test`` Python namespaces. The new ``pytest`` | ||
Python module flaty provides the same objects, following | ||
Python module flatly provides the same objects, following | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It could be that there's a module |
||
these renaming rules:: | ||
|
||
py.test.XYZ -> pytest.XYZ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally in English, doubled words aren't appropriate without punctuation, and often they're just errant.