backport annotations to 8.2 #12496
Merged
backport annotations to 8.2 #12496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the extra sphinx annotations to refer to Path instances add Path to nitpicky ignore
psf-chronographer
bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
changed the title
RonnyPfannschmidt
force-pushed
the
ronny/backport-annotations-8.2
branch
from
80e4b18 to
e60afd5
Compare
The-Compiler
requested changes
Jun 20, 2024
| ) -> None: | ||
| object.__setattr__(self, "args", tuple(args)) | ||
| object.__setattr__(self, "plugins", plugins) | ||
| object.__setattr__(self, "dir", dir) | ||
|
|
||
| cache: Cache |
There was a problem hiding this comment.
Suggested change
| cache: Cache | |
| # Set by cacheprovider plugin. | |
| cache: Cache |
for consistency with main (and less confusion).
Also, main has Cache | None here, but I think this is actually more correct? Looking at pytest_configure in cacheprovider.py I don't see a reason why this should ever be None...
src/_pytest/terminal.py
Outdated
| self, | ||
| which_reports: str, | ||
| sep_title: str, | ||
| *, |
There was a problem hiding this comment.
Seems unrelated, was this intended?
The-Compiler
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #12467