Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove git fetch from tox docs environment #13199

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Feb 6, 2025

It's a pain to have these when testing locally, they're unnecessary, and will prompt for ssh password (my ssh-agent env vars aren't passing through to tox).

Testing to see if this breaks CI

@jakkdl jakkdl added the skip news used on prs to opt out of the changelog requirement label Feb 6, 2025
@jakkdl jakkdl requested a review from webknjaz February 6, 2025 15:17
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's okay

@webknjaz webknjaz added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label Feb 6, 2025
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RonnyPfannschmidt
Copy link
Member

I vaguely recall that read the docs has a extra setting for this now

Let's crosscheck that just in case

@jakkdl
Copy link
Member Author

jakkdl commented Feb 6, 2025

I vaguely recall that read the docs has a extra setting for this now

Let's crosscheck that just in case

are you referring to the stuff in .readthedocs.yaml?

pytest/.readthedocs.yaml

Lines 24 to 26 in 1f1a10c

post_checkout:
- git fetch --unshallow || true
- git fetch --tags || true

idk if that's needed, but it also doesn't bother me when developing locally so /shrug

@RonnyPfannschmidt
Copy link
Member

It's needed and pretty much the replacement for the one you correctly removed

@jakkdl jakkdl merged commit de1a488 into pytest-dev:main Feb 7, 2025
28 checks passed
Copy link

patchback bot commented Feb 7, 2025

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/de1a4885d6fd27e4189aba94b8922acc58364142/pr-13199

Backported as #13200

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 7, 2025
remove `git fetch` from tox `docs` environment

(cherry picked from commit de1a488)
@jakkdl jakkdl deleted the tox_docs_no_fetch branch February 7, 2025 10:35
nicoddemus pushed a commit that referenced this pull request Feb 7, 2025
remove `git fetch` from tox `docs` environment

(cherry picked from commit de1a488)

Co-authored-by: John Litborn <[email protected]>
@webknjaz
Copy link
Member

webknjaz commented Feb 8, 2025

It's needed and pretty much the replacement for the one you correctly removed

@RonnyPfannschmidt do you remember why? It might not be. I think we dropped the dependency on Git from the Sphinx config in all envs to make cache work better on the sprint, right?

@RonnyPfannschmidt
Copy link
Member

We needed this for correct setuptools_scm Metadata on rtd

@webknjaz
Copy link
Member

webknjaz commented Feb 8, 2025

@RonnyPfannschmidt I thought so too. But when I checked earlier today, I haven't found evidence of setuptools-scm being used there.. Am I missing something?

@RonnyPfannschmidt
Copy link
Member

Install on rtd would fail due to shallow clones

@webknjaz
Copy link
Member

webknjaz commented Feb 8, 2025

@RonnyPfannschmidt are you sure? I think it was the case when there was setuptools-scm in play but not anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch skip news used on prs to opt out of the changelog requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants