-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove git fetch
from tox docs environment
#13199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I vaguely recall that read the docs has a extra setting for this now Let's crosscheck that just in case |
are you referring to the stuff in Lines 24 to 26 in 1f1a10c
idk if that's needed, but it also doesn't bother me when developing locally so /shrug |
It's needed and pretty much the replacement for the one you correctly removed |
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #13200 🤖 @patchback |
remove `git fetch` from tox `docs` environment (cherry picked from commit de1a488)
remove `git fetch` from tox `docs` environment (cherry picked from commit de1a488) Co-authored-by: John Litborn <[email protected]>
@RonnyPfannschmidt do you remember why? It might not be. I think we dropped the dependency on Git from the Sphinx config in all envs to make cache work better on the sprint, right? |
We needed this for correct setuptools_scm Metadata on rtd |
@RonnyPfannschmidt I thought so too. But when I checked earlier today, I haven't found evidence of |
Install on rtd would fail due to shallow clones |
@RonnyPfannschmidt are you sure? I think it was the case when there was |
It's a pain to have these when testing locally, they're unnecessary, and will prompt for ssh password (my ssh-agent env vars aren't passing through to tox).
Testing to see if this breaks CI