Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacken docs #3528

Merged
merged 2 commits into from
Jun 3, 2018
Merged

blacken docs #3528

merged 2 commits into from
Jun 3, 2018

Conversation

asottile
Copy link
Member

@asottile asottile commented Jun 3, 2018

Hi friends, I made a terrific (terrible? terrifying?) thing.

First commit is manual changes:

  • tabs to spaces
  • needed to add some ...s in a few places to make valid syntax

Second commit is automated!

Using the new thing I made today: https://github.com/asottile/blacken-docs

Heavily inspired by #3525. See also psf/black#292, psf/black#294. CC @blueyed

@coveralls
Copy link

coveralls commented Jun 3, 2018

Coverage Status

Coverage increased (+0.05%) to 92.753% when pulling 0f2d7dc on asottile:blacken_docs into 4dc5f78 on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

@asottile it seems its broken on windows ^^

@asottile
Copy link
Member Author

asottile commented Jun 3, 2018

/me shakes fists at charmap

easy fix

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@@ -14,7 +14,7 @@ Install argcomplete using::

For global activation of all argcomplete enabled python applications run::

sudo activate-global-python-argcomplete
sudo activate-global-python-argcomplete
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a false positive, no?

in a future major relase of pytest we will introduce class based markers,
at which points markers will no longer be limited to instances of :py:class:`Mark`
in a future major relase of pytest we will introduce class based markers,
at which points markers will no longer be limited to instances of :py:class:`Mark`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

@asottile
Copy link
Member Author

asottile commented Jun 5, 2018

@ambv if you read the description, I split it up into two commits (one manual, one automatic) -- among the first commit:

tabs to spaces

@ambv
Copy link

ambv commented Jun 5, 2018

Sorry, got confused by this.

ok-then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants