Use member names to initialize PyTypeObjects #8741
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowing an idea from #5201. Similar to #8734
As shown at https://docs.python.org/3/c-api/typeobj.html#examples, this uses member names to initialize
PyTypeObject
s, rather than being verbose and going through every member in sequence.Also, I've removed specifying
tp_flags
asPy_TPFLAGS_DEFAULT
, and so instead using the actual default from https://docs.python.org/3/c-api/typeobj.html#c.PyTypeObject.tp_flags,Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE
.https://docs.python.org/3/c-api/typeobj.html#c.Py_TPFLAGS_BASETYPE
I don't think we really need to specify that they can't be subtyped.