Remove rapidfuzz dependency #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
force-pushed
the
remove-rapidfuzz
branch
from
6a1bca5 to
7f9e968
Compare
bswck
requested changes
Nov 5, 2024
bswck
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
While the new implementation is not perfect, it does the job well enough for now. This will be replaced when the new parser is ready and better specced to handle subcommands (namespaces mess up a lot of things).
Why remove the dependency now?
Poetry 2.0 is going to be released soon and Cleo 3.0 is far from being ready. I want to release Cleo 2.2 which has no dependencies, so that we can trim down Poetry's dependency tree.