Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add in pre-commit config and some more CI/CD #232

Closed
wants to merge 8 commits into from
Closed

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Mar 1, 2024

Summary

Some quality of life changes

Details:

  • Use Ruff for linting, majority of file changes were are from this
  • Add in pre-commit conifg so that user don't forget 😉
  • Add both linting and testing github actions. NOTE: this is very non exhaustive, we don't currently have an gpu runners and even if we did they would need to be h100 or sm89 to significantly cover the tests we have, but something is better than nothing

One auxiliary change

  • While doing this PR I noticed that the c10d ops have been updated to _c10d so registered this ops to float8 tensor class and test/test_dtensor works

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2024
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always happy for lint/ci improvements!

@facebook-github-bot
Copy link
Contributor

@drisspg has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@drisspg merged this pull request in 607ff7b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants