Skip to content

Commit

Permalink
Use Almalinux-builder in linux-job by default (#5898)
Browse files Browse the repository at this point in the history
Use image build by: pytorch/pytorch#140157
This should support both Manylinux 2.28 wheels and old glibc 2.26
wheels. Tested by pulling Docker images and running some test.

Test:
```
docker pull pytorch/almalinux-builder:cpu-main
```

Test Wheel build with Manylinux 2.28:
```
>>> import torch
>>> from torch._C import *
>>> torch.__version__
'2.6.0.dev20241106+cpu'
```

Test Wheel build with manylinux-builder:
```
>>> import torch
>>> torch.__version__
'2.5.1+cu124'
>>> from torch._C import *
```

Example of Glibc failure with wheels from 2024.11.06:
https://github.com/pytorch/tensordict/actions/runs/11708894033/job/32611711890#step:12:734
  • Loading branch information
atalman authored Nov 12, 2024
1 parent 7b5e5cd commit 10cfd7c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/linux_job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ on:
type: string
docker-image:
description: Identifies the Docker image by name.
default: "pytorch/manylinux-builder"
default: "pytorch/almalinux-builder"
type: string
docker-build-dir:
description: |
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
name: ${{ inputs.job-name }}
env:
DOCKER_IMAGE: >-
${{ inputs.docker-image == 'pytorch/manylinux-builder' && format('pytorch/manylinux-builder:{0}{1}',
${{ inputs.docker-image == 'pytorch/almalinux-builder' && format('pytorch/almalinux-builder:{0}{1}',
inputs.gpu-arch-type,
inputs.gpu-arch-version)
|| inputs.docker-image }}
Expand Down

0 comments on commit 10cfd7c

Please sign in to comment.