Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disablebot] Allow reading of disable issue for multiple tests #6045

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Dec 11, 2024

The expected format of a disable issue for multiple tests is
Title: DISABLED MULTIPLE

Body:
additional info
disable the following tests:

test_name (test_suite): platforms, mac
test_name2 (test_suite):

additional info

For example

image

Tested by running old version and new version and diffing the files. There was no change

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 6:52pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2024
@clee2000 clee2000 marked this pull request as ready for review December 11, 2024 22:26
@clee2000 clee2000 requested a review from a team December 11, 2024 22:28
@huydhn
Copy link
Contributor

huydhn commented Dec 12, 2024

Do you think it would be simpler to not have an aggregated issues for tests disabled by the bot? #6044 (comment). Basically,

@ZainRizvi
Copy link
Contributor

Do you think it would be simpler to not have an aggregated issues for tests disabled by the bot? #6044 (comment). Basically,

The challenge here is that we need a way to notify test owners when their tests get disabled. A json file is handy for tracking, but needs more support to make the new tests discoverable

Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, what about if we supported prefixes in the disable issue name instead?

For example, the title could be "DISABLED PREFIX test_foo_bar" and that issue would only disable test starting with that prefix. (And it could list them out so that the disabling doesn't become overzealous)

Given that test storms are likely to affect related tests, that approach may do the trick while still letting us create separate issues for tests that are different enough.

@huydhn
Copy link
Contributor

huydhn commented Dec 13, 2024

IMO, we could focus on cleaning up the spams issue first, for example, write a script to close all disabled tests issue what match a certain pattern, and follow up with a proper design discussion on this. I suspect that there might not be a quick solution for this after all

@clee2000 clee2000 force-pushed the csl/disable_bot_read_multi branch from 81b9262 to 1e91120 Compare December 20, 2024 17:46
@clee2000 clee2000 requested review from a team and ZainRizvi December 20, 2024 17:54
@clee2000 clee2000 force-pushed the csl/disable_bot_read_multi branch from 30e10d6 to c4aec4e Compare December 20, 2024 18:08
@huydhn
Copy link
Contributor

huydhn commented Jan 7, 2025

Should we create a mock disabled multiple tests issue on PyTorch and try to run the script manually to confirm?

@huydhn
Copy link
Contributor

huydhn commented Jan 7, 2025

Also, do you remember if we take the title of the issue into account? I wonder if we should enforce something like the disabled tests in the issue body need to belong to the test file / test class set by the title

@clee2000
Copy link
Contributor Author

clee2000 commented Jan 9, 2025

Should we create a mock disabled multiple tests issue on PyTorch and try to run the script manually to confirm?

Tested with pytorch/pytorch#144481, it did generate the 3 extra tests in the file

Also, do you remember if we take the title of the issue into account? I wonder if we should enforce something like the disabled tests in the issue body need to belong to the test file / test class set by the title

It does not. The only ways that I know of to validate that an issue only contains tests from a certain file would be to run the test file or to check a database. I think these two options are both a bit excessive. It is also possible that there is one underlying reason for multiple tests to break. However, the flaky test bot does have information about tests when it makes disable issues, so my plan is to have the bot separate by file when makes the issues, but not have anything to enforce this separation if a user decides they want to do something else

@clee2000 clee2000 force-pushed the csl/disable_bot_read_multi branch from c4aec4e to a90a527 Compare January 9, 2025 18:52
@clee2000 clee2000 merged commit 73fbf31 into main Jan 9, 2025
7 of 8 checks passed
@clee2000 clee2000 deleted the csl/disable_bot_read_multi branch January 9, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants